rshendershot / MythRokuPlayer

mythtv front end for Roku player
tbd
8 stars 2 forks source link

Video coverart images aren't captured and displayed #50

Closed patna closed 9 years ago

patna commented 9 years ago

All of the videos under /var/lib/mythtv/videos show up in Roku as blank white images on the Date menu. Mythfrontend is able to pull up the coverart OK. Also, I checked that the permissions on the coverart/ folder are the same (mythtv user, mythtv group) as the recordings/ folder.

Tried adding a video_covers symlink, but that didn't help:

drwxrwsr-x 2 mythtv mythtv 4.0K Nov 24 20:48 coverart/ lrwxrwxrwx 1 root root 24 Nov 23 20:49 video_covers -> /var/lib/mythtv/coverart/

The coverart/ directory has .jpg files (one for each video) that MythTV retrieved as metadata and stored in the database. They have the appropriate group read permissions for the web user (mythtv in my case).

Filing as per rshendershot's request on the MythRokuPlayer forums.

rshendershot commented 9 years ago

There are two mechanisms used for preview images:

"/var/lib/mythtv/videos" inidicates we're working the second case. When there is no screenshot, a grey oval should be displayed.

Please modify player_feed.php: 257

            $imgfile = !empty($screenart) && !empty($show->screenshot) ? $screenart->dirname . $show->screenshot : "images/oval_grey.png";
            error_log("ISSUE_50_imgfile: $imgfile", 0);             

...and let me know what you see.

patna commented 9 years ago

The screenshots/ directory under /var/lib/mythtv/ is indeed empty and I get the following error log with the change: [Sat Nov 29 16:09:25.546402 2014] [:error] [pid 2972] [client 192.168.1.2:55056] ISSUE_50_imgfile: images/oval_grey.png

The coverart for the video are under the coverart/ folder. Is there a recommended way to get screenshots generated for all video files under /var/lib/mythtv/videos?

rshendershot commented 9 years ago

I'm going to make the assumption that what you described as 'blank white images' is actually the grey_oval. Closing as not a bug. If I've misunderstood then feel free to re-open with new information.

rshendershot commented 9 years ago

How to get metadata lookup to correctly identify the videos itemized in VideoMetadata is, first, a MythTV issue not a problem in MRP code; So, I refer you to MythTV documentation. And secondly more of a problem for screenshots than for cover art as tvimdb may not have screenshots for everything so it's, thirdly, dependent on external reference sites resources.

That said, if you look at the code that you just modified you can see where coverart can be used instead of screenshots. Also a couple of link to documentation resources.

patna commented 9 years ago

Sorry for the confusion. Yes, by "blank white images", I did mean the grey_oval.png file being loaded.

I will go and look at the code some more and try to replace screenshots with coverart instead since MythTV seems to populate the coverart/ folder just fine from external site references. Thanks for the tip and for your time looking into this.