rshk / python-libxdo

Python bindings for libxdo
BSD 3-Clause "New" or "Revised" License
76 stars 19 forks source link

Change in xdo_search_t structure #29

Open amasmiller opened 2 years ago

amasmiller commented 2 years ago

When using python-libxdo v0.1.2a1 against libxdo version 3.20210903.1, I found the xdo_search_windows function was not working as expected.

I traced down the issue to a changed xdo_search_t structure made in this recent change to libxdo.

After making this modification:

+++ /usr/local/lib/python3.5/dist-packages/xdo/xdo.py   2021-10-19 11:39:04.453431051 
-0500
@@ -229,20 +229,23 @@

     # const char *winclass; pattern to test against a window class
     ('winclass', c_char_p),

     # const char *winclassname; pattern to test against a window class
     ('winclassname', c_char_p),

     # const char *winname; pattern to test against a window name
     ('winname', c_char_p),

+    # const char *winrole; pattern to test against a window role
+    ('winrole', c_char_p),
+
     # int pid; window pid (From window atom _NET_WM_PID)
     ('pid', c_int),

     # long max_depth; depth of search. 1 means only toplevel windows
     ('max_depth', c_long),

     # int only_visible; boolean; set true to search only visible windows
     ('only_visible', c_int),

     # int screen; what screen to search, if any. If none given,

After the modification, the search worked as expected.