search

rsieiro / RSOAuthEngine

ARC based OAuth engine for MKNetworkKit
http://rodrigo.sharpcube.com
150 stars 33 forks source link

Update dependency #14

Closed ikesyo closed 11 years ago

ikesyo commented 11 years ago

At recent MKNetworkKit, 'NSData+Base64.{h,m}' was renamed to 'NSData+MKBase64.{h,m}'.

This PR fix #import directive and demo projects' reference to the files.

JefferE commented 11 years ago

@ikesyo - is this why the demo project is currently broken in master?

ikesyo commented 11 years ago

@JefferE - I tried using demo project (Twitter) in master, and it successfully worked.

I think there are some possible reasons.

  1. submodule(MKNetworkKit) isn't cloned
  2. you didn't remove thre "#error ..." line in RSTwitterEngine.m
  3. TW_CONSUMER_KEY, and/or TW_CONSUMER_SECRET aren't filled

for 1st, after cloning thre repo, you should do

$ git submodule init
$ git submodule update

or when cloning, use '--recursive' option, or use Github for Mac to clone (install the app, and click "Clone in Mac" button).

for 3rd, to retrive consumer key and cosumer secret, you need to make your own application at dev.twitter.com.

At that time, you should fill "Callback URL" column. Because RSOAuthEngine only supports callback style, but not PIN based style.

If "Callback URL" is blank, Twitter API will be PIN based mode, so it returns error response in oauth dance. (it doesn't accept "oauth_callback" parameter.)

ikesyo commented 11 years ago

Sorry, those tips above are written in README ;-)

JefferE commented 11 years ago

Yes, I had already done all those steps but was getting all kinds of build errors about non-existent files.

But after I posted that question to you I tried to pull your changes into my local repo to see if it fixed the build issues but couldn't do it (I'm an svn guy and not used to git commands yet).

So I deleted my whole local clone and recloned and it magically worked first shot.

I assumed it was because your pull request got processed and your changes were now incorporated, but now I'm not sure why it started working.

On Fri, Jan 11, 2013 at 2:02 PM, Syo Ikeda notifications@github.com wrote:

@JefferE https://github.com/JefferE - I tried using demo project (Twitter) in master, and it successfully worked.

I think there are some possible reasons.

  1. submodule(MKNetworkKit) isn't cloned
  2. you didn't remove thre "#error ..." line in RSTwitterEngine.m
  3. TW_CONSUMER_KEY, and/or TW_CONSUMER_SECRET aren't filled

for 1st, after cloning thre repo, you should do

$ git submodule init $ git submodule update

or when cloning, use '--recursive' option, or use Github for Mac to clone (install the app, and click "Clone in Mac" button).

for 3rd, to retrive consumer key and cosumer secret, you need to make your own application at dev.twitter.com.

At that time, you should fill "Callback URL" column, because RSOAuthEngine only supports callback style, but not PIN based style.

If "Callback URL" is blank, Twitter API returns error response in oauth dance. (the API doesn't accept "oauth_callback" parameter.)

— Reply to this email directly or view it on GitHubhttps://github.com/rsieiro/RSOAuthEngine/pull/14#issuecomment-12158501.

rsieiro commented 11 years ago

Thanks for that. Already merged :)