search

rsim / oracle-enhanced

Oracle enhaced adapter for ActiveRecord
MIT License
545 stars 307 forks source link

support LIKE case-insensitive matching #2247

Closed akostadinov closed 2 years ago

akostadinov commented 2 years ago

Oracle documentation suggests to use UPPER() when case-insensitive search is desired. I have used that here. Without it the comparison is only case-sensitive unlike MySQL and Postgres where it can be one or the other by user choice.

Probably upgrade notes should point out that by default matching is case-insensitive. If anybody used it as case-sensitive without passing the case_sensitive parameter to #matches, then they can be surprised by this change.

yahonda commented 2 years ago

Note: This change is breaking one so it will not be backported to the release70 branch.