Closed swamp09 closed 2 years ago
Thanks for opening a pull request. Would you make sure this test fails against Rails main branch (7.1.0.alpha) and Oracle enhanced adapter master branch? If so, I'm happy to merge this pull request and backport them to release70 and release61 branches.
Tests failed on the Rails main branch and Oracle enhanced adapter master branch. Ruby version is 2.7.2. OracleDB version is Oracle Database 11g Express Edition.
Thank you for the confirmation. Let me backport it to release70 and release61 branches.
Running
ARCONN=oracle bundle exec ruby -Itest ./test/cases/finder_test.rb -n test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct
in Rails 6.1.4.4 will result in an error.Fixing the return value of
columns_for_distinct
causes the test to pass. This is a fix for the change to PostgreSQL and MySQL adapters in Rails 6.0. https://github.com/rails/rails/pull/31966The reason why the tests for
ARCONN=oracle bundle exec ruby -Itest ./test/cases/finder_test.rb -n test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct
don't pass is because of a fix in finder_methods.rb in Rails 6.1. https://github.com/rails/rails/commit/2ad2425fd3b3a58e937f97b1fa05306c4d3166ae