search

rsim / oracle-enhanced

Oracle enhaced adapter for ActiveRecord
MIT License
545 stars 307 forks source link

Merge pull request #2249 from swamp09/fix_columns_for_distinct #2252

Closed yahonda closed 2 years ago

yahonda commented 2 years ago

This pull request backports #2249 to the releae61 branch.

yahonda commented 2 years ago

RuboCop offenses are reported because #2204 has not been backported to the release61 branch. This will not be backported. Just ignore these offenses.

yahonda commented 2 years ago

Setting continue-on-error to run RSpec while RuboCop offenses are found. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error

yahonda commented 2 years ago

I think these two failures can be ignored for now.

https://github.com/rsim/oracle-enhanced/runs/4883400954?check_suite_focus=true https://github.com/rsim/oracle-enhanced/runs/4883401153?check_suite_focus=true

yahonda commented 2 years ago

Let's remove continue-on-error by force-push.