search

rsim / oracle-enhanced

Oracle enhaced adapter for ActiveRecord
MIT License
545 stars 307 forks source link

Enable `RSpec/RepeatedExample` cop #2278

Closed yahonda closed 2 years ago

yahonda commented 2 years ago

This cop actually finds the actual repeated examples below. So let's remove them.

$ bundle exec rubocop
Inspecting 72 files
....................................................C...................

Offenses:

spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:219:5: C: RSpec/RepeatedExample: Don't repeat examples within an example group.
    it "should dump table comments" do ...
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:226:5: C: RSpec/RepeatedExample: Don't repeat examples within an example group.
    it "should dump column comments" do ...
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:233:5: C: RSpec/RepeatedExample: Don't repeat examples within an example group.
    it "should dump table comments" do ...
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb:240:5: C: RSpec/RepeatedExample: Don't repeat examples within an example group.
    it "should dump column comments" do ...
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

72 files inspected, 4 offenses detected
$
koic commented 2 years ago

Nice improvement!