search

rsim / oracle-enhanced

Oracle enhaced adapter for ActiveRecord
MIT License
546 stars 308 forks source link

Set permissions for GitHub actions #2286

Closed nathannaveen closed 2 years ago

nathannaveen commented 2 years ago

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests

Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

Signed-off-by: nathannaveen 42319948+nathannaveen@users.noreply.github.com

yahonda commented 2 years ago

Thanks for opening a pull request. After reviewing https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ I do not think we need to merge this pull request.