search

rsim / oracle-enhanced

Oracle enhaced adapter for ActiveRecord
MIT License
546 stars 308 forks source link

Lazy load type mappings #2301

Closed andynu closed 2 years ago

andynu commented 2 years ago

This appears to fix issue #2256. I believe it should have the same memory implications as the intention in #2199. The type maps are loaded once when they are first called. Only one instance of the mapping is ever created.

Fortunately this was enough to solve the problem, but if there were a need, this could easily be worked into the clear_cache! API to reset it at a later point in the application just by setting the @type_map to nil.

(clean patch against the master branch, nothing from the release70 here)

JRDVN commented 2 years ago

@andynu, @yahonda Hey! Any news about this issue? I have the exact same issue on a project and it would be nice to have some fix.

andynu commented 2 years ago

I'd be delighted if this PR were merged. If there is anything I can do to help that along I'd be happy to do it.

Meanwhile @JRDVN Here is a monkey patching initializer workaround. https://gist.github.com/andynu/9522d16ab85fd4ec2c2c31903fbe249d