search

rsim / oracle-enhanced

Oracle enhaced adapter for ActiveRecord
MIT License
545 stars 308 forks source link

Address `Style/RedundantRegexpEscape` offense #2322

Closed yahonda closed 1 year ago

yahonda commented 1 year ago

This commit addresses the following offense.

$ bundle exec rubocop -a
Inspecting 72 files
...................C....................................................

Offenses:

lib/active_record/connection_adapters/oracle_enhanced/quoting.rb:29:33: C: [Corrected] Style/RedundantRegexpEscape: Redundant escape inside regexp literal
          when /^[a-z][a-z_0-9$#\-]*$/i
                                ^^

72 files inspected, 1 offense detected, 1 offense corrected
$
yahonda commented 1 year ago

This offense is found since RuboCop 1.39.0 via https://github.com/rubocop/rubocop/issues/11150

yahonda commented 1 year ago

https://github.com/rsim/oracle-enhanced/actions/runs/4486089284/jobs/7888254172?pr=2322 is green now.

yahonda commented 1 year ago

@koic Even though our CI is failing, can you review this pull request?

koic commented 1 year ago

Yup, this cop's behavior is an expected and the new code is compatible with the prior code. Thank you!