Refactored, so the call to "require 'spec_helper'" is no longer needed in each spec file.

rsim / ruby-plsql-spec

Oracle PL/SQL unit testing with Ruby

MIT License

68 stars 25 forks source link

Refactored, so the call to "require 'spec_helper'" is no longer needed in each spec file. #26

Closed jgebal closed 8 years ago

jgebal commented 8 years ago

Call to plsql-spec init now creates additional file: .rspec in the project root directory.

The file contains a require, so the spec_helper is always required. This way when writing tests, the spec helper no longer needs to be explicitly required.

jgebal commented 8 years ago

@javornikolov any concerns/comments on this change?

javornikolov commented 8 years ago

I think --requrie option was introduced with rspec 3.x (and perhaps the transitional 2.99 version too). So I'm wondering whether we should do something to keep things compatible.

jgebal commented 8 years ago

Good spot. I did not check before. The --require option was included since 2.14 What is the policy for backward compatibility in this project? Do you think it would be worth/advisable to use the most recent features of underlying libraries, even if it means bumping the project version by a number to indicate it's no longer backward-compatible?

jgebal commented 8 years ago

@javornikolov I've added fixes and a test for new file.

javornikolov commented 8 years ago

Good spot. I did not check before. The --require option was included since 2.14 What is the policy for backward compatibility in this project? Do you think it would be worth/advisable to use the most recent features of underlying libraries, even if it means bumping the project version by a number to indicate it's no longer backward-compatible?

I think there is no strict policy for backward compatibility. It may be tricky - depends on users' environments.

But to be honest - in this case:

rspec 2.x seems to survive unknown extra options in .rspec
the examples are already using expect syntax which is not available in rspec 2 (so it anyway needs some tweaking to adapt to older versions). But these are just examples

Also I think rspec < 2.4 is not working with latest ruby.

So I guess we're not breaking anything significant by this change.

jgebal commented 8 years ago

All test were passing after my latest fix. Do you think it's worth merging? I have a backlog of small tweaks and extensions, so few pull requests might be coming soon.

javornikolov commented 8 years ago

:shipit: Merging... @jgebal , thank you for adding this enhancement!

jgebal commented 8 years ago

Thanks. It's a pleasure.