search

rsim / ruby-plsql-spec

Oracle PL/SQL unit testing with Ruby
MIT License
68 stars 25 forks source link

Fixed coverage support for PACKAGE Body so that lines covered in PACK… #43

Closed vonahnen closed 7 years ago

vonahnen commented 7 years ago

…AGE headers aren't counted towards it.

vonahnen commented 7 years ago

Not sure who maintains the build scripts for this repo, but the script .travis/oracle/install.sh is failing...

unzip: cannot find zipfile directory in one of oracle-xe-11.2.0-1.0.x86_64.rpm.zip or oracle-xe-11.2.0-1.0.x86_64.rpm.zip.zip, and cannot find oracle-xe-11.2.0-1.0.x86_64.rpm.zip.ZIP, period.

javornikolov commented 7 years ago

Thank you @vonahnen for this pull request! Would it be feasible to add some tests for that change?

javornikolov commented 7 years ago

Not sure who maintains the build scripts for this repo, but the script .travis/oracle/install.sh is failing...

unzip: cannot find zipfile directory in one of oracle-xe-11.2.0-1.0.x86_64.rpm.zip or oracle-xe-11.2.0-1.0.x86_64.rpm.zip.zip, and cannot find oracle-xe-11.2.0-1.0.x86_64.rpm.zip.ZIP, period.

I'll have a look at that. We had a similar issue with ruby-plsql. I'll double check if the solution which we used there is still working and apply it here soon.

vonahnen commented 7 years ago

Awesome, and yes I can write some tests. I'll update once I get a chance to write those.

javornikolov commented 7 years ago

I managed to fix the Travis CI setup of Oracle (the related PR #44 is already merged into master).

vonahnen commented 7 years ago

@javornikolov - tests updated.

javornikolov commented 7 years ago

Thank you @vonahnen! It looks good to me. Merging...