Subtitle files not showing up again.

[MidoriGreenMidori]

[quackend]

me too.

const WEBVTT_FMT = 'webvtt-lssdh-ios8'; //old?

const WEBVTT_FMT = 'nflx-cmisc'; //new?

fetch(url).then(function(response) { if (response.ok) { return response.blob(); } throw new Error('Bad response to WebVTT request'); }).then(function(blob) { //maybe this code isn't running? webvttCache.set(cacheKey, new Blob([blob], {type: 'text/vtt'})); // set type to avoid warning renderAndReconcile(); }).catch(function(error) { console.error('Failed to fetch WebVTT file', error.message); });

[Essam311]

me too.

const WEBVTTFMT = 'webvtt-lssdh-ios8'; //old?_

const WEBVTTFMT = 'nflx-cmisc'; //new?_

fetch(url).then(function(response) { if (response.ok) { return response.blob(); } throw new Error('Bad response to WebVTT request'); }).then(function(blob) { //maybe this code isn't running? webvttCache.set(cacheKey, new Blob([blob], {type: 'text/vtt'})); // set type to avoid warning renderAndReconcile(); }).catch(function(error) { console.error('Failed to fetch WebVTT file', error.message); });

You can use this workaround which used before the last time subadub stopped working https://github.com/rsimmons/subadub/issues/12#issuecomment-562431398, install this chrome extension and subadub will work again.

https://chrome.google.com/webstore/detail/language-learning-with-ne/hoombieeljmmljlkjmnheibnpciblicm

In the "Learn Language With Netflix" extension interface turn it off if you will only use it to make Subadub working again.

[quackend]

Thank you so much!

[Essam311]

Using @mwhirls fix https://github.com/mwhirls/jimakun/commit/9c430445517061384326dac4f96589625d5f99da for the same problem in his extension "jimakun" fixed Subadub for me.

https://github.com/Essam311/subadub/commit/b3626affe615b14b52b463b2bcdfb7943a97e3a8

@mwhirls Could you please port your fix to Subadub?

[mwhirls]

@Essam311 I don't mind, I can do it later today. Since you already have the fix in your fork though, feel free to go ahead and put up a pull request for it if you'd like.

[Essam311]

@mwhirls Thank you so much, I made a pull request.

[Essam311]

@mwhirls Sorry I will close my PR, the fix will be much better if you ported it.

[mwhirls]

@Essam311 Oh okay, no problem. Pull request added that fixes the bug: https://github.com/rsimmons/subadub/pull/19

[Essam311]

@mwhirls Thank you so much, the fix is working great on both Firefox and Google chrome.

[rsimmons]

The new version has been published for both Chrome and Firefox. Thank you @MidoriGreenMidori for reporting, and thank you @mwhirls for the patch!

[Essam311]

@mwhirls Subadub is broken again, most likely a similar problem for the previous one, would you please check if it could be fixed? Thanks.

[mwhirls]

@Essam311 Yeah, it was the same issue, Netflix keeps changing their API. I put up a more robust fix this time, so hopefully it will be less of an issue in the future.

[Essam311]

@mwhirls Thank you so much, I tested your PR and it works perfectly on Google Chrome.

[Essam311]

@bun906 You could use the fixed Subadub from here.

https://github.com/rsimmons/subadub/issues/20#issuecomment-612777747