search

rsimmons / subadub

Chrome+Firefox extension for studying foreign languages using Netflix subtitles
MIT License
126 stars 38 forks source link

Get best available subtitles #21

Closed MaxCilauro closed 4 years ago

MaxCilauro commented 4 years ago

Previously, it was hardcoded to use the first CDN id to get the subtitle's download url, but it is not always available. This fix checks for the first CDN id that has a corresponding subtitle url, and uses it to display the subs.

fixes #20

WilsonNet commented 4 years ago

This fixed for me (Firefox), thank you very much.

true-zero commented 4 years ago

How has this still not been reviewed?

true-zero commented 4 years ago

@rsimmons review this

rsimmons commented 4 years ago

Thanks for this, sorry it took forever to merge. I've submitted updated builds for Chrome and Firefox.