rsimmons / voracious

A video player for studying foreign languages (esp. Japanese)
https://voracious.app
MIT License
327 stars 38 forks source link

Language detection on subtitle files may be wrong, and there is no recourse #23

Open rsimmons opened 5 years ago

rsimmons commented 5 years ago

Павел Кузнецов emailed me that a certain subtitle file would display but wouldn't show dictionary definitions. The problem is that even though the subs are Japanese, there are "junk" Dialogue lines in the .ass file that cause the language detection to detect it as German, so no analysis/lookup is done.

I'm not sure how to fix detection, but theoretically there could be some way to override the detection result.

Geniusssmit commented 5 years ago

Yes, there was actually german lines before japanese