rsimmons / voracious

A video player for studying foreign languages (esp. Japanese)
https://voracious.app
MIT License
331 stars 38 forks source link

Episode progress #38

Open cessen opened 4 years ago

cessen commented 4 years ago

Implement a timestamp in the library view that shows how much of each video has been watched.

This makes it much easier to keep track of where you are in e.g. a long series. Videos with less than two seconds watched don't show the timestamp.

Screenshot: episode_progress_screenshot

chriskempson commented 4 years ago

Nice! Unfortunately I think @rsimmons has abandoned this project and views https://github.com/rsimmons/subadub as its successor.

I'm still using this software but can't yet make use of Subadub as it's not as feature complete as Voracious. Perhaps it is time for a new maintainer or fork?

EiEiO11490 commented 4 years ago

Perhaps it is time for a new maintainer or fork?

Are you @chriskempson going to be the person to do that? Or will @cessen be the one?

cessen commented 4 years ago

Nice! Unfortunately I think @rsimmons has abandoned this project and views https://github.com/rsimmons/subadub as its successor.

Has he actually said that anywhere? I'm not specifically doubting you, it would just be good to get confirmation from him about that if we can before forking.

Perhaps it is time for a new maintainer or fork?

I have a (personal) branch that I'm maintaining at https://github.com/cessen/voracious/tree/my_version that has quite a lot of changes to it (including upgrading to the latest stable electron, and an added feature to color words in subtitles similar to LingQ and the Language Learning with Netflix chrome addon).

I don't have the bandwidth to be the maintainer for a project like this, but if someone does want to start a fork, my personal branch might be a reasonable jumping-off point. If anyone does want to do that, let me know, and I can document all the changes I've made (some of them are trivial and you might want to roll back, like hot key changes).

EiEiO11490 commented 4 years ago

@cessen can you make a complete release of your version so i can download it?

cessen commented 4 years ago

@EiEiO11490 I don't have the time or energy to maintain releases of my personal branch. But you're more than welcome to build it yourself. The build instructions in the readme should still work just fine.

Do note, however, that I've only tested it on Linux (since that's what I run). It should work on Windows and OSX as well, but I haven't made 100% sure.

EiEiO11490 commented 4 years ago

@cessen I do not know anything about javascript. I am only a noob in C#. so i would not know how to do anything in the readme. Can anyone of this be done in Visual studio or Notepad++?

cessen commented 4 years ago

@EiEiO11490 Ah, sorry about that, then. Honestly, unless you run Linux as your OS, I'm not sure how to make a build for you either (I don't have a Windows or OSX computer, and I'm not sure how to cross-build electron apps for them--Javascript isn't really my wheelhouse either).

chriskempson commented 4 years ago

@EiEiO11490 That wont be me, too busy for that sorry but if someone picks this up I'd be interested in contributing to it (time permitting).

@cessen @rsimmons emailed me back in Feb 2019 saying he was "tempted to" drop Voracious and roll the features into Subadub. So technically, I guess it isn't officially dropped but I'll stand by what I said when I wrote I think he has abandoned it 😄