rsimon / immarkus

An image annotation environment for the MARKUS platform
GNU Affero General Public License v3.0
12 stars 2 forks source link

Carry undo/redo history over to the new Annotator when adding/removing images to workspace #56

Open rsimon opened 8 months ago

rsimon commented 8 months ago

The undo/redo stack is tied to the Annotator instance. If a second image is added to a workspace that only has a single image, the existing image will be unmounted, and a new window (with a new Annotator) will be mounted. This means that the previous undo/redo history is lost. We should add functionality for carrying over the history of the old (unmounted) Annotator to the new Annotator.

StoIva commented 7 months ago

one question about this: are we planning to make undo/redo possible once the image is closed and reopened? this is currently not possible, but would be good to know how excatly the two buttons work so we can put that in the instructions

rsimon commented 7 months ago

I'm afraid it's not possible to undo a step that you made before closing the image (or closing IMMARKUS). Once you close the image view, the history is gone. If we wanted change this, we'd need to save a full version history record with every image, which would be a bigger change.

Carrying over the history when adding a new image to the workspace is less of a problem, because then the application is still in the same "session", as it were. In this case, the history is still in memory. But once you leave the annotation view entirely, the undo/redo history is erased.

StoIva commented 7 months ago

ok good to know. that should be in the instructions

rsimon commented 7 months ago

Agreed! 👍