search

rsinghlab / SCOT

Gromov-Wasserstein based optimal transport for aligning single-cell multi-omics data
http://rsinghlab.github.io/SCOT
MIT License
66 stars 16 forks source link

Errors when running the coembed_datasets() method #10

Closed barthcaron closed 1 year ago

barthcaron commented 1 year ago

Hi,

I've been trying to work with the co-embedding version of scot V2, and I think there are a few typos in the coembed_datasets() method of the scotv2 class. Once corrected, its seems to work fine, but I'd prefer if you could tell me if the changes I made in the corresponding pull request are legit?

RESOLVES #9

Thanks for your help and for your very nice work

Barthelemy Caron, postdoc in Ivan Costa's lab at RWTH Aachen.

Cbaker37 commented 1 year ago

Hi,

I've just made your edits to the SCOTv2 file, and ran the unbalanced SNAREseq example to make sure it replicates the original results. Thanks for pointing this out!

Best, Colin