search

rsjaffe / MIDI2LR

An application and plugin to remotely control Lightroom with a MIDI controller
http://rsjaffe.github.io/MIDI2LR/
GNU General Public License v3.0
686 stars 83 forks source link

Consider auto-sync flag when applying settings #386

Closed mathieucarbou closed 6 years ago

mathieucarbou commented 7 years ago

See: https://groups.google.com/forum/#!msg/midi2lr/siYOF2WL8UY/azWt0SKwCwAJ

Right, the patch that I added go through applying develop settings now and for that we have to target an image. The problem is not new: other settings are also applied only to the target image.

The culprit is this line in client utilities I think:

LrApplication.activeCataloggetTargetPhotoapplyDevelopSettings():():(settings)

Rory: I don't know if we can check the status of the auto-sync switch. Do we ? If we can, we could add an if statement that applies to all with: catalog:getTargetPhotos().

I am also wondering if just using catalog:getTargetPhotos() would take in consideration the auto-sync switch…

rsjaffe commented 7 years ago

No, we can't check the auto-sync switch.

mathieucarbou commented 7 years ago

And do you know if catalog:getTargetPhotos() (which is different than getting the selected photos) would consider it ? Meaning that if no tenabled, the list would have 0 or 1 item and if enabled, the list would have 0..N items ?

If it works like that, then we could use catalog:getTargetPhotos() instead of trying to get the target photo

rsjaffe commented 6 years ago

Duplicate of #414