search

rsjaffe / MIDI2LR

An application and plugin to remotely control Lightroom with a MIDI controller
http://rsjaffe.github.io/MIDI2LR/
GNU General Public License v3.0
689 stars 83 forks source link

Support for modifiers (key combination) #Enhancement #417

Closed abrilevskiy closed 7 months ago

abrilevskiy commented 6 years ago

It will be nice to have support of modifiers (key combination):

  1. Press two or more button in same time - separate "virtual" button
  2. Press one or more button and rotate knob in same time - separate "virtual" knob
rsjaffe commented 6 years ago

That's what profiles are for.

andreipopovici commented 4 years ago

It would be great to have momentary-switch profile support (i.e. a knob responds differently if turned while a drum pad or note is pressed or "on"), instead of needing to toggle between profiles.

Is that something that could be configured using the existing options, or would it fall under "new feature request"?

rsjaffe commented 4 years ago

That would be a new feature request.

andreipopovici commented 4 years ago

Thank you! For context, here's how I'm using this feature in Capture One (via Bome MIDI Translator):

I have three relative-mode knobs set to Hue, Saturation and Lightness. Then, I use a momentary press on one of three drum pads to make each knob control the H, S or L for either shadows, midtones or highlights, only while the respective drum pad is pressed.

In MIDI2LR, it could work by temporarily activating a specific profile on "Note On" and reverting to the first or default profile on "Note Off", in addition to the current mode, which only enables a profile on "Note On".

D-Noc commented 4 years ago

I think this is an excellent idea. It would make it possible to have the Basic profile selected, and then, while pressing a button, the profile would switch to e.g. the Details profile. Releasing the button would switch back to the Basic profile. Only caveat I can think of is that the pressed button cannot be assigned to do something else in the Details profile. Perhaps this Feature Request ties in with https://github.com/rsjaffe/MIDI2LR/issues/463 ??

rsjaffe commented 4 years ago

I like the temporary profile idea. That's relatively easy to implement within the current framework of the program.

tss68nl commented 4 years ago

I was about to leave a similar feature request so instead I support this motion :) Please include this feature in Midi2LR.

I think it's easily possible to assign another function to the same button in the 'details' profile, as Note-start will trigger the details profile, while Note-end will trigger the return to the previous profile. Note-start can be attached to something entirely different in the details profile, should you also be able to choose the details profile with a permanent switch.

This enables you to quickly jump into HSL mode for some luminance adjustments, while the same modifier will work differently when you permanently switch to HSL mode, for example by letting you adjust the Hue's under the same modifier.

This feature would make Midi2LR so much more powerful.... can't wait!

tpj2018 commented 1 year ago

Perhaps you can use bome to send a note on and off when pressed down which selects a different profile. Then on release bome sends a different note on/off which then selects the previous profile. Not ideal as you need to add bome to midi2lr, but this could perhaps work.