search

rsjaffe / MIDI2LR

An application and plugin to remotely control Lightroom with a MIDI controller
http://rsjaffe.github.io/MIDI2LR/
GNU General Public License v3.0
675 stars 83 forks source link

MIDI2LR does not recognize relative encoder positions anymore #460

Closed HuFux closed 4 years ago

HuFux commented 4 years ago

@rsjaffe

Describe the bug I have an Arturia Beatstep board, which has endless rotary encoders and therefore does not need a pickup mode, because the knobs act in relative mode and automatically pick up the parameter of each individual picture, allowing for a seamless edit. But with V3.3.2.0 this has changed. The rotary knobs no longer pick up the parameters of each individual picture after switching between the pictures, but instead continue on the new picture with the value from the previous picture. Therefore there are sudden parameter jumps when rotating the knob the first time on a new picture. The knobs act like the behavior would be if you have limited rotary knobs set to "absolute mode" without pickup mode enabled. In V3.3.1.0 everything is fine. Bug introduced in V3.3.2.0.

To Reproduce Steps to reproduce the behavior:

  1. Set Arturia Beatstep knobs to "Relative 2" mode
  2. Set Arturia Beatstep knobs acceleration to "OFF"
  3. Allocate "Brightness" to one rotary knob in MIDI2LR
  4. Set "two's complements", resolution 127 to all rotary knobs in MIDI2LR
  5. Take two pictures, each of them with brightness set to 0
  6. Correct brightness of first picture via the knob to -4.0
  7. Switch to the second picture
  8. Move the knob just a little bit and the brightness will jump from 0 to -4.1 instantly

-> Knob is acting like "absolute" mode, despite of setting "two's complement"

Bug is present in V3.3.2.0 Bug is NOT present in V3.3.1.0

Expected behavior I would have expected, that the brightness of the second picture would not instantly jump to -4.1. Instead the brightness slider should start to move at its current position. So I would have expected that it would move to -0.1 instead.

Screenshots

System(please complete the following information):

Additional context If you need more information or a tester to test a bug-fix, please contact me any time. Thanks

rsjaffe commented 4 years ago

Just tested latest version and it works as expected for all relative value types. No action needed.

TheDude-hr commented 4 years ago

Hi rsjaffe,

Same problem with the same midi controller . I confirm that this bug seems to be introduced with version 3.3.2.0. Everything is working fine with 3.3.1.0. To complete HuFux post :

To Reproduce :

--> the setting move from value previously set by knob and not by mouse.

Expected behavior (as in 3.3..1.0) :

--> the setting move from value previously set by mouse.

System :

Windows 10 Pro 1909 64 bit Lightroom version 9.0 MIDI2LR version 3.3.2.0 and 3.4.2.1

HuFux commented 4 years ago

@rsjaffe Just tested latest version also on a different PC and it does still not work as expexted for all relative value types. Thanks @TheDude-hr for third party confirmation and re-opening. Action is definitely needed. Wirklich, das macht so keinen Spaß !

NKame commented 1 year ago

Nice to see it documented, now I know to which version I should revert to :-)