search

rsjaffe / MIDI2LR

An application and plugin to remotely control Lightroom with a MIDI controller
http://rsjaffe.github.io/MIDI2LR/
GNU General Public License v3.0
686 stars 83 forks source link

MIDI2LR qui unexpectedly at first launch #465

Closed jbrialon closed 4 years ago

jbrialon commented 4 years ago

Describe the bug Hello, right after I installed MIDI2LR, when I launch Lightroom, MIDI2LR crashes and I get an error

To Reproduce Steps to reproduce the behavior:

  1. Launch Lightroom
  2. wait 5s
  3. MIDI2LR crashes and I get an error
  4. See error

Expected behavior MIDI2LR to launch

Screenshots

Screenshot 2019-12-13 at 17 50 42

System(please complete the following information):

Additional context MIDI2LR.log

jbrialon commented 4 years ago

it's working with the MIDI2LR-3.3.1.0-MacOS-CATALINA release

rsjaffe commented 4 years ago

That information was pretty specific. Looks like there's a concurrency issue in rsj::GetKeyboardLayout in Ocpp.mm. I'll try to lock the message loop there. Could you try replacing MIDI2LR.app with the version that's in https://www.dropbox.com/s/j3qjexfevqqts7k/MIDI2LR1.zip?dl=0 ? It has the lock.

rsjaffe commented 4 years ago

If my interpretation is correct, the latest release (3.3.4.0) should address the problem. https://github.com/rsjaffe/MIDI2LR/releases . Please reply on this issue whether or not the fix worked. Thanks.

jbrialon commented 4 years ago

I updated to 3.3.40 and now it's working