rsjaffe / MIDI2LR

An application and plugin to remotely control Lightroom with a MIDI controller
http://rsjaffe.github.io/MIDI2LR/
GNU General Public License v3.0
673 stars 83 forks source link

Crop functions not considering photo orientation #608

Open onegrasshopper opened 2 years ago

onegrasshopper commented 2 years ago

Describe the bug The current crop implementation seems to assume "AB" orientation photos only, not considering a photos getDevelopSettings()["orientation"] which could be "BC", "CD", or flipped, etc

This also affects the RatioCrop function in clientutilities.

Gives strange behavior on any photo not with AB orientation.

To Reproduce Steps to reproduce the behavior:

Expected behavior Consistent behavior

System(please complete the following information):

wunditta commented 10 months ago

As for now this cannot be fixed. The function returning the orientation (getDevelopSettings['Orientation']) seems to have a bug as it always returns 'nil'. So currently it is not possible to take the orientation into account within the plugin.

I reported a bug with Adobe for this.