search

rsjaffe / MIDI2LR

An application and plugin to remotely control Lightroom with a MIDI controller
http://rsjaffe.github.io/MIDI2LR/
GNU General Public License v3.0
686 stars 83 forks source link

Unassigned lines not removed in localized install (french) #646

Closed Taolu-03 closed 2 years ago

Taolu-03 commented 2 years ago

I run a french version of Lightroom and MIDI2LR.

When an "unassigned" line is created in the MIDI2LR configuration, it cannot be removed by the "remove unassigned" button.

The label on the button is translated correctly (Non assigné) and also the remove button (Supprimer les lignes non attribuées). However, in the xml configuration file generated when you save your configuration, it is still labeled "Unassigned" which might be the cause of the problem. (I guess the erase button function uses the localized label to search for lines to erase).

If I reverse back to english for Lightroom, MIDI2LR is launched in english and the button is now working again.

I'm on OSX 10.4.6 french (Mojave), Lightroom Classic 10.4 and MIDI2LR 4.3.1.11

Exposure.xml.zip

Screenshot 2022-04-08 à 18 02 14

rsjaffe commented 2 years ago

I tested foreign languages in the current release (which is the only release I will fix), and delete unassigned worked correctly. I did take this opportunity to simplify the class involved (will be in new release, not pushed to github yet).