search

rsjaffe / MIDI2LR

An application and plugin to remotely control Lightroom with a MIDI controller
http://rsjaffe.github.io/MIDI2LR/
GNU General Public License v3.0
673 stars 83 forks source link

Contrast and Shadows nob not recognize preset value #709

Closed adrianpytlikadrian closed 4 months ago

adrianpytlikadrian commented 1 year ago

Discussed in https://github.com/rsjaffe/MIDI2LR/discussions/697

Originally posted by **kindian123** September 10, 2022 Hi, after updating to the latest release I have this issue. Currently using updated Lightroom with Behringer X Touch Mini and latest MIDI2LR. I have a preset with +30 contrast, +30 shadows, using Behringer top nobs before with no issues. Now I have to drag them down to reach something above +30, I guess it starts Contrast with +54 or something when it's actually at +30, doesn't always happen with Shadows. This issue always happened to me with the vertical slider never with the top nobs. Anyone with this issue? Update: tested the Quick Develop Contrast and Quick Develop Shadows and it works fine, too bad because I have only -5/+5 steps not -1/1 like in Basic Tone adrianpytlikadrian: I have a problem with the contrast and shadow knob. The values are "stuck" on some number and to change the value you have to go back to the given value to make it work.
darthdurden commented 1 year ago

@adrianpytlikadrian are you still having this issue? I'm seeing similar issues with the X Touch Mini. I think I've tracked it down to when I switch between layer A and layer B on the controller. Is that what you're seeing as well? @rsjaffe When these don't work (at least for me) I see 2 different values in the adjustment overlay, both the new value that is trying to be set as the dial twists as well as the stuck value. Once I reach close to the stuck value, it goes down to a single value and works as usual.

adrianpytlikadrian commented 1 year ago

Hi! Still same problem on my xtouch mini. But I don't see problem in switching between layers. Problem is only in contrast and shadows dial.

darthdurden commented 1 year ago

@adrianpytlikadrian ah gotcha, its weird. Can you confirm something for me. If you're on a photo and switch layers, do the LEDS on the dials always match the values of the photo? I seem to have some issues there. Especially if I double tap the A layer, it puts all of the LEDs to 0 and then causes weird behavior. Trying to determine if that is a software or hardware issue. Thanks!

rsjaffe commented 4 months ago

Fixed in https://github.com/rsjaffe/MIDI2LR/commit/4605af1b46ef52cae9ecfabf0a35fdca7a5718d5