search

rsjaffe / MIDI2LR

An application and plugin to remotely control Lightroom with a MIDI controller
http://rsjaffe.github.io/MIDI2LR/
GNU General Public License v3.0
700 stars 83 forks source link

Fork wunditta/MIDI2LR #746

Closed wunditta closed 10 months ago

wunditta commented 1 year ago

Currently it is very difficult to decide how to proceed with this project. I started with my fork wunditta/MIDI2LR to iron out some smaller issues and some little changes. But now I am afraid it gets out of hands. Before it can or never will be accepted to join with this repository I urgently would need some feedback from you, rsjaffe.

What are your plans with this? Will you maintain it further? If so, do you see any chance to join our forks? I am willing to contribute in any helpful way. I could also undo some changes and add them step by step.

One of the major issues is, that I am now moving most functions from Profiles to ClientUtilities as there were functions in each requesting functions from the other (after I added some features). I am afraid that soon it will be impossible to join both forks. This change is not reflected on Git so far, only locally. But as I will fix some bugs with the current pre-release I will have to upload that as well.

antzpantz commented 1 year ago

I hope we hear from rsjaffe soon and also that they are well.

On Sat, 23 Sept 2023 at 22:34, wunditta @.***> wrote:

Currently it is very difficult to decide how to proceed with this project. I started with my fork wunditta/MIDI2LR https://github.com/wunditta/MIDI2LR to iron out some smaller issues and some little changes. But now I am afraid it gets out of hands. Before it can or never will be accepted to join with this repository I urgently would need some feedback from you, rsjaffe.

What are your plans with this? Will you maintain it further? If so, do you see any chance to join our forks? I am willing to contribute in any helpful way. I could also undo some changes and add them step by step.

One of the major issues is, that I moved most functions from Profiles to ClientUtilities as there were functions in each requesting functions from the other (after I added some features). I am afraid that soon it will be impossible to join both forks.

— Reply to this email directly, view it on GitHub https://github.com/rsjaffe/MIDI2LR/issues/746, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFIYPFGLIMOHTFYMIZWLKFLX33XPXANCNFSM6AAAAAA5EHUL6E . You are receiving this because you are subscribed to this thread.Message ID: @.***>

rsjaffe commented 1 year ago

I hope to join the forks sometime soon. I stepped away because I was getting burnt out with some of the more obscure bugs and wasn't getting any help. Now that you're working on it too, I feel better about getting back. I should do so within a month (can't get to it until then). Still need significant help with Mac Silicon processor peculiarities as I don't have a machine set up to debug that processor.

antzpantz commented 1 year ago

I've started to look into what goes on behind scripting for Lightroom with MIDI2LR but my programming skills haven't been used in nearly 10 years!

On Sat, 23 Sept 2023 at 23:19, rsjaffe @.***> wrote:

I hope to join the forks sometime soon. I stepped away because I was getting burnt out with some of the more obscure bugs and wasn't getting any help. Now that you're working on it too, I feel better about getting back. I should do so within a month (can't get to it until then). Still need significant help with Mac Silicon processor peculiarities as I don't have a machine set up to debug that processor.

— Reply to this email directly, view it on GitHub https://github.com/rsjaffe/MIDI2LR/issues/746#issuecomment-1732340773, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFIYPFAKYDMC52LTFBZB4K3X334YFANCNFSM6AAAAAA5EHUL6E . You are receiving this because you commented.Message ID: @.***>

wunditta commented 1 year ago

I hope to join the forks sometime soon. I stepped away because I was getting burnt out with some of the more obscure bugs and wasn't getting any help. Now that you're working on it too, I feel better about getting back. I should do so within a month (can't get to it until then). Still need significant help with Mac Silicon processor peculiarities as I don't have a machine set up to debug that processor.

Very nice to hear from you :-) . I really hope I did not mess things up in an uncontrollable way... ;-)

Just for reference, this are the issues which should be solved with my fork:

rsjaffe commented 12 months ago

I'm now actively working on the update. It's going to take a while because there's a lot to do. I try to use Lightroom's translation strings when possible. If I can't for some of the additions, I'll have to work on the translations, which may delay those feature's inclusion. I don't include any un-localized strings, as there are lots of non-English speakers using this application.

rsjaffe commented 11 months ago

6.0 is out for testing (see discussion forum). It has some of your simpler updates. I am slowly reviewing the other ones for possible future release.

rsjaffe commented 11 months ago

Undoing some of the changes I haven't yet included and reintroducing them step-by-step would help greatly.

Normally when I'm developing a new feature, I commit all the changes for that specific feature as a single commit, with all the changes in the affected files included. That way, it is much easier to understand the changes and correct issues as they arise.

Thanks again for your work!

wunditta commented 10 months ago

Hi,

I am deeply sorry for being silent so long. I had a rough time and would need another one or two weeks until I can concentrate on this project again. Things should be cleared up then and I can continue with the work.

Are you still interested in merging the two repositories?

Best regards, Dieter

From: rsjaffe @.> Sent: Mittwoch, 31. Jänner 2024 21:21 To: rsjaffe/MIDI2LR @.> Cc: wunditta @.>; Author @.> Subject: Re: [rsjaffe/MIDI2LR] Fork wunditta/MIDI2LR (Issue #746)

Closed #746 https://github.com/rsjaffe/MIDI2LR/issues/746 as completed.

— Reply to this email directly, view it on GitHub https://github.com/rsjaffe/MIDI2LR/issues/746#event-11660908334 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AMBGJA3TBY6NDVBIMHRM6CLYRKRTJAVCNFSM6AAAAAA5EHUL6GVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGY3DAOJQHAZTGNA . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AMBGJA44VO4GOKMYWSMS3ALYRKRTJA5CNFSM6AAAAAA5EHUL6GWGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAFNYLK4XA.gif Message ID: @. @.> >

rsjaffe commented 10 months ago

Probably not. I've gone on from there a long ways, am currently working on a way to allow fine adjustments that integrates with current methods and am close to a beta test release. Thanks for your work, and after the next release, feel free to fork and work on it some more.