search

rsjudge17 / ubiquity-xforms

Automatically exported from code.google.com/p/ubiquity-xforms
0 stars 0 forks source link

Relevance on group appears to be broken #594

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I've witnessed behaviour in some forms, which suggests that relevance may not 
be working correctly on group elements. I'll provide more thorough 
description than that as I investigate the bug further.

Original issue reported on code.google.com by phil.boo...@gtempaccount.com on 19 Oct 2009 at 2:28

GoogleCodeExporter commented 9 years ago 
I'm attaching a form that demonstrates this issue.

Looking in the debugger, it seems that isEnabled() always returns true for the 
group 
in this form, because isWired is never set to true on it. The isWired property 
should 
be set to true in a closure that is spawned during Model.addControl(). However, 
that 
code is not executed, despite being correctly called from 
MIPHandler.addcontroltomodel(), because Model.m_bIsReady is false at the time. 
I've 
no idea whether that is supposed to be the case or what.

The other possibility is that the call to getProxyNode() in isEnabled should 
come 
before the test of the isWired property. The precise reason for the existence 
of 
isWired is something I'm quite unsure about at the moment, but hopefully more 
investigation will remedy that.

Original comment by phil.boo...@gtempaccount.com on 19 Oct 2009 at 3:58

Attachments:

GoogleCodeExporter commented 9 years ago 
Awaiting review at r3096.

Original comment by phil.boo...@gtempaccount.com on 20 Oct 2009 at 10:21

GoogleCodeExporter commented 9 years ago 
This problem was occurring because the setting of Container.isWired to true was 
not 
happening in all necessary paths of execution. The changes at r3097 rectify 
this, by 
moving the code into MIPHandler.rewire().

Marking this issue as fixed.

Original comment by phil.boo...@gtempaccount.com on 20 Oct 2009 at 2:26

GoogleCodeExporter commented 9 years ago 
Issue 452 has been merged into this issue.

Original comment by phil.boo...@gtempaccount.com on 20 Oct 2009 at 2:29

GoogleCodeExporter commented 9 years ago 
Issue 459 has been merged into this issue.

Original comment by phil.boo...@gtempaccount.com on 20 Oct 2009 at 2:32