search

rsjudka / intelligent-auto

41 stars 15 forks source link

Suppress libusb compile warnings #35

Open stefan-sherwood opened 4 years ago

stefan-sherwood commented 4 years ago

This same change can also be done for subprojects aasdk/ and openauto/ though I'm not sure the correct protocol for doing that.

rsjudka commented 4 years ago

this seems like more of a hack doesn't it?

I think a cleaner way of fixing this would be done something like this: https://github.com/openDsh/aasdk/pull/2/files (just look specifically at the libusb stuff but you could always bring the other fixes in too)

stefan-sherwood commented 4 years ago

I must be misunderstanding, It looks like the include isn't needed, in which case the library could also be removed. But if it is needed, it doesn't look like that fix would work.

(I assumed it was being used)

rsjudka commented 4 years ago

there is an include, it just moved to the Findlibusb-1.0.cmake module

stefan-sherwood commented 4 years ago

Ah, now I see it. The fix amounts to the same thing as mine. It suppresses warnings because it's labeled as a system include.