search

rsjudka / intelligent-auto

41 stars 15 forks source link

[Enhancement] Control Buttons #37

Closed robert5974 closed 4 years ago

robert5974 commented 4 years ago

As requested, here are the items requested to change or update in the Control Buttons:

  1. Add a pop-up menu for the power button. Choose between Shutdown, Reboot, & Cancel

  2. Add pop-up or notification acknowledging the actual saving of settings when the Save button is pressed

  3. Possibly adding the selected theme color to the buttons when pressed ( just a thought)

robert5974 commented 4 years ago

Should I edit this title to include "[Enhancement]" preceding?

rsjudka commented 4 years ago

went ahead and did it :slightly_smiling_face:

need to start getting better organized with all this hah

robert5974 commented 4 years ago

Ok. Thanks. I thought it was something you labeled afterwards lol. I've never been this involved on GitHub. I just remember the guy developing Crankshaft going back and marking what needed to be an enhancement and not only an issue.

rsjudka commented 4 years ago

power button pop up: Screenshot from 2020-06-14 17-43-46

save notifier: Peek 2020-06-14 17-46

decided not to add the transparent backdrop for now because I'm not sure where transparency can currently be supported

because this relies on being to show the pop ups at the topmost layer, this wont get merged into develop until the openauto gstreamer stuff gets merged in (and made to be the only supported openatuo platform)

robert5974 commented 4 years ago

Looks good! Looking forward to it.