search

rsjudka / intelligent-auto

41 stars 15 forks source link

Crash if clicking mic #7

Closed leobel96 closed 4 years ago

leobel96 commented 4 years ago

I have Google Assistant disabled on my Android smartphone and, if I click che microphone button of the Android Auto interface, it crashes and I have to unconnect/connect the cable again. A message saying "You have to enable Google Assistant on your smartphone in order to use this feature" would be great in my opinion.

rsjudka commented 4 years ago

Unfortunately, I don't have control over the actual Android Auto interface so I can't manipulate it in any sort of way... I could add some more gotchas pertaining to that tho Thanks for pointing this out to me!

leobel96 commented 4 years ago

I thought it was a problem of OpenAuto and, so, you could fix it

rsjudka commented 4 years ago

oh i meant about adding the "You have to enable Google Assistant on your smartphone in order to use this feature" message. Or maybe OpenAuto does generate the UI too? To be honest I havent looked that deep into it hah I havent ran into this or seen it mentioned before, but I can look into it and see how I can handle it in OpenAuto so that it doesnt crash

leobel96 commented 4 years ago

I meant to show the message on OpenAuto UI but, honestly, I don't know if OpenAuto generates the UI

rsjudka commented 4 years ago

so I just did some testing, but I wasn't able to reproduce your issue. I'm wondering if this was somehow related to all the other crashes (since it plays audio when clicking the mic) and thus has been fixed.

Let me know if this is no longer an issue and we can get this closed!

leobel96 commented 4 years ago

I tested it now and the issue seems fixed. Great work! I also noticed that double-clicking Android Auto makes it full screen but it is not mentioned in the README. Please add it!