search

rsksmart / rLogin

A web tool that combines Web3 and W3C standard protocols to manage user's identity
MIT License
25 stars 20 forks source link

Control which browser providers are shown #262

Open kazazor opened 2 years ago

kazazor commented 2 years ago

At the moment, I cannot determine which browser providers appear. We would like to hide the Nifty wallet and not show it by default.

jessgusclark commented 2 years ago

With the deprecation of Nifty wallet, we can hide Nifty from the row unless the user has it installed.

Will that work, or are you also looking to hide Liquality?

kazazor commented 2 years ago

At the moment, we're only looking on hiding Nifty and not liquality. So that will work for now :)

ilanolkies commented 2 years ago

What do you think about adding a hideInjectedProviders optional config, that is backwards compatible + easy to implement + easy to understand

jessgusclark commented 2 years ago

I think we can add hideInjectedProviders as an option, however, as a quick fix let's change the variable on this line to false for Nifty wallet to only show it if the user has it installed.

This can be handled as part of this ticket or it can be with #278 which duplicates this part.

kazazor commented 2 years ago

I would like to suggest a different approach that will solve both this issue and https://github.com/rsksmart/rLogin/issues/230 which was closed. Instead of showing multiple buttons for each browser extension, show just one button for all of them together.

That way we're solving both topics:

  1. No one needs to control which wallets to show and which to hide
  2. The experience is clear as you only have an option to have 1 browser wallet at a time (unlike the current experience as we see in https://github.com/rsksmart/rLogin/issues/230)

An example of a GREAT protocol that did it is AAVE: Screen Shot 2022-06-01 at 9 40 49

This is SO CLEAR and you have a bunch of wallets in the image there which is very clear.

WDYT?