Discussion: what to do if the user use a wallet that has not been tested for encryption

rsksmart / rif-identity-manager

Manage your identity, assets, credentials, storage and reputation in a single platform!

https://identity.rifos.org/

MIT License

1 stars 5 forks source link

Discussion: what to do if the user use a wallet that has not been tested for encryption #48

Closed javiesses closed 3 years ago

javiesses commented 3 years ago

I think we should assume that if the wallet is not Metamask, we should not try to encrypt. Let's create an issue out of this

_Originally posted by @javiesses in https://github.com/rsksmart/rif-identity-manager/pull/44#discussion_r562116438_

miltonwg commented 3 years ago

Agree. At this moment we should assume that and inform the user that the encryption feature is not enabled for any non-metamask wallet (same way we do with Nifty and WC).

jessgusclark commented 3 years ago

The best way to do this is given the provider: (provider.isMetaMask && !provider.isNifty)

Because Nifty wallet will return true forisMetaMask.

jessgusclark commented 3 years ago

I am going to close this as we are using an asymmetric encryption method for non Metamask wallets.