search

rsksmart / rif-relay

Meta-transaction support for RSKJ
Other
11 stars 17 forks source link

PP-633/relay-server-tests #238

Closed franciscotobar closed 1 year ago

franciscotobar commented 1 year ago

What

Why

Refs

franciscotobar commented 1 year ago

The PR has a lot of Forbidden non-null assertion, due to the fact that the getSigners() is an array return. I dont like that but I dont like to do a force type conversion to fix it, Im not sure what should be the proper approach.

antomor commented 1 year ago

The PR has a lot of Forbidden non-null assertion, due to the fact that the getSigners() is an array return. I dont like that but I dont like to do a force type conversion to fix it, Im not sure what should be the proper approach.

I'd prefer to force the type conversion instead of having the non-null assertion, just because it's in a single point, instead in this way we need to use the non-null assertion each time we use those variables.

antomor commented 1 year ago

I think the PR needs to be rebased, but LGTM