search

rsksmart / rns-manager-react

RNS Manager - ⌨️ buidling
https://manager.rns.rifos.org/
MIT License
6 stars 13 forks source link

Remove the restriction to be connected to web3 provider before it is really necessary #363

Open miltonwg opened 3 years ago

miltonwg commented 3 years ago

When trying to search for a domain and know the price and years options, the RNS Manager requests the user to connect with a web3 provider such as Metamask/Nifty/WalletConnect. As the user has not taken any blockchain action they should not be requested to do that. The need for that is after the user presses the “Request to register” button.

Steps to reproduce:

  1. Go to https://manager.rns.rifos.org without a browser wallet extension in place
  2. Insert a valid and available domain name and press “Search” button
  3. Press “Register” button
  4. You’ll be prompted with this screen # 1:
image

The idea is to change step 4 --> The user should be directed to this screen # 2 with no additional actions needed:

image

And then, screen # 1 should only appear after the user presses “Request to register" button (if still not connected to a web3 provider).

This will make that non-crypto users can know for how long they could register the RNS domain and how much would it cost before having to have any blockchain knowledge nor wallet.

jessgusclark commented 3 years ago

Step 1 checks if the user has RIF before allowing the user to click "Request to Register". Moving the login to after this step could result in the user wasting gas on the first transaction if they don't have the funds for the second.

jessgusclark commented 3 years ago

Remove the initial check of the RIF tokens and wait until after.

New proposed flow:

  1. User sees the registration page
  2. User clicks on register
  3. Wallet is requested and user logs in
  4. App checks if the user has enough RIF
    • No? then show an error
    • Yes! then continue