search

rsksmart / rns-manager-react

RNS Manager - ⌨️ buidling
https://manager.rns.rifos.org/
MIT License
6 stars 13 forks source link

feat: adding not enough RIF balance before troughing transaction #545

Closed annipi closed 9 months ago

annipi commented 9 months ago

REM-31

The user should not be able to start domain purchasing operation if they do not have enough RIF balance to save gas.

Screenshot 2024-02-22 at 11 15 00 AM
antomor commented 9 months ago

I've also tried to reproduce the error experienced by @AndresQuijano, but I couldn't

annipi commented 9 months ago

@AndresQuijano

I found two things: -The message is always in English despite the lenguaje configuration. -I found a bug:

  1. Try to buy a domain with a wallet with 0 RIF.
  2. It shows the error message.
  3. Fund the same wallet with some RIFs.
  4. Try again.
  5. The error message is shown anyway.
  1. I fixed the issue of the error message not changing when the language changed.
  2. Apparently this behavior of still seeing an error if the error box not explicity closed(if the page gets reload this does happen), is consistent for all other error messages as well, we can create a ticket to address this, at least for the develop branch since this is an improvement.
sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud