Use EIP-1191 checksums in MetaMask

[bguiz]

Use EIP-1191 checksums in MetaMask

Prize Bounty

0.01450 RBTC

(approximately 900 USD at time of posting)

Challenge Description

Users can currently use the MetaMask browser extension to interact with the RSK network within DApps. However, there are a couple of minor incompatibilities which currently require the use of workarounds. This task is to eliminate this by allowing the user to configure 1 of 2 new options in MetaMask’s “Custom Network” feature, and using those values.

The 2 new options are “Derivation Path” and “Checksum uses Chain ID”. This bounty is only about “Checksum uses Chain ID”. If you attempt this bounty, we suggest that you also attempt the other bounty about “Derivation Path”, because if you complete one of these bounties, the other related bounty is likely to be much easier to complete, due to the similarity of the 2 tasks.

• In the “Custom Network” screen, expose a field named “Checksum uses Chain ID”. It should have an “info” icon next to it which displays a “tool tip” that says “When selected, calculate EIP1191 checksums using Chain ID.”
• Presently MetaMask does expose a field named “Chain ID”, which is used in several other areas, but does not use this during checksum calculation. This means that it uses EIP-55 for checksum calculations.
• RSK, on the other hand, uses EIP-1191, which is an extension of EIP-55. When a Chain ID is provided, it is used as an input in the checksum calculation; and when a Chain ID is not provided, it defaults to EIP-55 checksums (backwards compatibility).
• The change should include changing the invocations of MetaMask’s checksumAddress to modify the function calls to ethereumjs-util’s toChecksumAddress to pass in the optional value of eip1191ChainId whenever “Checksum uses Chain ID” is present.

Submission Requirements

• Integration should be written using Javascript and it should be submitted as a GIthub PR on the MetaMask browser extension repo
• Also include a link to your own public Github repo with the git branch used in the Github PR submitted on the MetaMask browser extension repo
• Note that if you are attempting both related bounties (“Derivation Path” and “Checksum uses Chain ID”), they should be attempted separately, and submitted as separate Github PRs on separate git branches.
• Implement the features as described in the “challenge description” section
• Add tests that provide coverage for the new features added
• Refer to MetaMask’s contributing docs for instructions on how to develop on this repo.

Judging Criteria

• Only one submission allowed per participant. Where a participant wishes to resubmit, update the original submission instead of submitting a separate entry.
• If the submission involves a graphical user interface of any variety, please include a video recording of it in action.
• If the submission involves a command line interface of any variety, please include a text file of it in action (including outputs).
• Test coverage for any implementation is viewed favourably: More test coverage is better.
• In cases where the bounty requires a Github PR on an existing repo, and that repo has continuous integration (CI) set up, the PR should not fail on the CI steps.
• Documentation is viewed favourably: Include specific instructions on how to set up and use your submission. Optionally, include any explanations of architectural/ design choices that went into the submission.
• The easier it is for the reviewer to run and understand the submission, the better, so be sure to consider this in your submissions!

Winner Announcement Date

• This bounty is part of a hackathon, and there are three significant dates:
  • Start date: 15/04/2021
  • End date: 14/05/2021
  • Results date: 15/06/2021
• Submissions are welcome between the start date and the end date.
• Reviews will be conducted between the end date and the results date.
• All submissions must be submitted prior to the end date in order to be eligible for a bounty award.
• Submissions submitted or resubmitted after the end date may not be awarded any bounty.
• All submissions must be reviewed and accepted (successfully pass the review) prior to the results date in order to be eligible for a bounty award.
• The bounty will be awarded on the Gitcoin platform to the best submission among all eligible submissions for this bounty.

More information

• For questions related to this bounty, and other bounties in this hackathon, please join the RSK Slack, and check out the #gitcoin2021 channel.
• To learn more about RSK and RIF technologies, check out our Developer Portal.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 0.0145 RBTC (900.39 USD @ $62096.0/RBTC) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
  • Want to chip in? Add your own contribution here.
  • Questions? Checkout Gitcoin Help or the Gitcoin's Discord
  • $2,133,877.14 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work has been started.

These users each claimed they can complete the work by 4 days, 1 hour from now. Please review their action plans below:

1) niondevi has started work.

I will attempt to implement the features as described1 2) mjosephd has started work.

Hackathon Submission 3) pdptk has started work.

Use the blockchain to create segregated witness 4) anukul has started work.

Will make PR by end of day IST. WIP commit: https://github.com/anukul/metamask-extension/commit/bbaf8d0

Learn more on the Gitcoin Issue Details page.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work for 0.0145 RBTC (778.03 USD @ $53988.0/RBTC) has been submitted by:

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin's Discord
• $2,423,375.07 more funded OSS Work available on the Gitcoin Issue Explorer