Implement EIP-1898 in RSKj RPC methods

bguiz commented 3 years ago

Implement EIP-1898 in RSKj RPC methods

Prize Bounty

0.03370 RBTC

(approximately 2100 USD at time of posting)

Challenge Description

Modify RSKj’s implementation for the following RPC methods to support EIP-1898:

eth_getBalance
eth_getStorageAt
eth_getTransactionCount
eth_getCode
eth_call

The full details of the change required in these RPC methods’ implementations is specified in EIP-1898. A quick summary of it would be to state that these RPC methods should also additionally accept not just the existing string formats, but now also accept objects, similar to the following:

{ "blockNumber": "0x0" }
{ "blockHash": "0xf88529d4ab262c0f4d042e9d8d3f2472848eaafe1a9b7213f57617eb40a9f9e0", "requireCanonical": false }

Both of the above should reference RSK’s genesis block when used in the above RPC methods.

Submission Requirements

The submission is expected to be:

A Github pull request on the RSKj repository
Implement the features as described in the “challenge description” section
- RSKj should be EIP-1898 compliant as a result of this change
Add tests that provide coverage for the new features added

Judging Criteria

Only one submission allowed per participant. Where a participant wishes to resubmit, update the original submission instead of submitting a separate entry.
If the submission involves a graphical user interface of any variety, please include a video recording of it in action.
If the submission involves a command line interface of any variety, please include a text file of it in action (including outputs).
Test coverage for any implementation is viewed favourably: More test coverage is better.
In cases where the bounty requires a Github PR on an existing repo, and that repo has continuous integration (CI) set up, the PR should not fail on the CI steps.
Documentation is viewed favourably: Include specific instructions on how to set up and use your submission. Optionally, include any explanations of architectural/ design choices that went into the submission.
The easier it is for the reviewer to run and understand the submission, the better, so be sure to consider this in your submissions!

Winner Announcement Date

This bounty is part of a hackathon, and there are three significant dates:
- Start date: 15/04/2021
- End date: 14/05/2021
- Results date: 15/06/2021
Submissions are welcome between the start date and the end date.
Reviews will be conducted between the end date and the results date.
All submissions must be submitted prior to the end date in order to be eligible for a bounty award.
Submissions submitted or resubmitted after the end date may not be awarded any bounty.
All submissions must be reviewed and accepted (successfully pass the review) prior to the results date in order to be eligible for a bounty award.
The bounty will be awarded on the Gitcoin platform to the best submission among all eligible submissions for this bounty.

More information

For questions related to this bounty, and other bounties in this hackathon, please join the RSK Slack, and check out the #gitcoin2021 channel.
To learn more about RSK and RIF technologies, check out our Developer Portal.

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.0337 RBTC (2092.64 USD @ $62096.0/RBTC) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin's Discord
- $2,142,098.26 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 week, 2 days from now. Please review their action plans below:

1) skarchon has started work.

Implement EIP-1898 In RSKj RPC Methods 2) elmol has started work.

Working on Implement EIP-1898 In RSKj RPC Methods 3) gusleyva has started work.

Looking to implement a new method that solves this issue.

Learn more on the Gitcoin Issue Details page.

bguiz commented 3 years ago

NOTE: Updated to remove eth_getProof from the list of RPCs.

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.0337 RBTC (1806.42 USD @ $53609.0/RBTC) has been submitted by:

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin's Discord
$2,040,100.36 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.0337 RBTC (1872.51 USD @ $49671.0/RBTC) has been submitted by:

@elmol

@bguiz please take a look at the submitted work:

PR by @elmol

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin's Discord
$2,524,331.23 more funded OSS Work available on the Gitcoin Issue Explorer

rsksmart / rsk-gitcoin-hackathon-2021