search

rsksmart / rskj

RSKj is a Java implementation of the Rootstock protocol.
https://rootstock.io
GNU Lesser General Public License v3.0
670 stars 268 forks source link

Support RSKIP712 #1353

Open julianlen opened 4 years ago

julianlen commented 4 years ago

In order to have support for typed structured data hashing and signing, is necessary implement the RSKIP712 (a reference to EIP712).

PR here

diegomasini commented 4 years ago

To add more context to this issue: GSN tests relay on this method. In our opinion it is not a good approach to force a blockchain client to implement this functionality just for testing. We decided to remove this need from Enveloping by doing local signing in the project code.

We wanted to keep record of this situation here since we do not know if this feature will be requested for a real use case in the future. We did an implementation of eth_signTypedData in the PR referenced in this issue, it is not the best way to solve it due to the dependencies it introduces, but it could be used as a reference implementation if at some point this functionality is needed.