search

rsksmart / rskj

RSKj is a Java implementation of the Rootstock protocol.
https://rootstock.io
GNU Lesser General Public License v3.0
670 stars 268 forks source link

Remove Apache Commons Lang dependency #806

Open diega opened 5 years ago

diega commented 5 years ago

Following with our effort to reduce dependencies, the Apache Commons Lang doesn't add much value and thus must be removed

To remove from build.gradle: org.apache.commons:commons-lang3:3.5

Contributors: We welcome PRs removing usages of this library. We don't expect anyone to do it all at once.

diega commented 5 years ago

I'm reopening this until the whole dependency gets removed from the build.gradle

joaquinlpereyra-iov commented 5 years ago

Hello. Just in case it helps anyone, these are the files where this dependency is being used:


./main/java/co/rsk/util/IpUtils.java:import org.apache.commons.lang3.StringUtils;
./main/java/co/rsk/peg/BridgeSerializationUtils.java:import org.apache.commons.lang3.tuple.Pair;
./main/java/co/rsk/peg/BridgeSupport.java:import org.apache.commons.lang3.tuple.Pair;
./main/java/co/rsk/peg/BridgeStorageProvider.java:import org.apache.commons.lang3.tuple.Pair;
./main/java/co/rsk/pcc/blockheader/GetMergedMiningTags.java:import org.apache.commons.lang3.ArrayUtils;
./main/java/co/rsk/net/discovery/PeerExplorer.java:import org.apache.commons.lang3.StringUtils;
./main/java/co/rsk/net/discovery/message/NeighborsPeerMessage.java:import org.apache.commons.lang3.builder.ToStringBuilder;
./main/java/co/rsk/net/discovery/message/PeerDiscoveryMessage.java:import org.apache.commons.lang3.builder.ToStringBuilder;
./main/java/co/rsk/net/discovery/message/FindNodePeerMessage.java:import org.apache.commons.lang3.builder.ToStringBuilder;
./main/java/co/rsk/net/discovery/message/PongPeerMessage.java:import org.apache.commons.lang3.builder.ToStringBuilder;
./main/java/co/rsk/net/discovery/message/PingPeerMessage.java:import org.apache.commons.lang3.builder.ToStringBuilder;
./main/java/org/ethereum/vm/program/invoke/ProgramInvokeFactoryImpl.java:import static org.apache.commons.lang3.ArrayUtils.nullToEmpty;
./main/java/org/ethereum/core/BlockHeader.java:import org.apache.commons.lang3.ArrayUtils;
./main/java/org/ethereum/core/CallTransaction.java:import static org.apache.commons.lang3.ArrayUtils.subarray;
./main/java/org/ethereum/core/CallTransaction.java:import static org.apache.commons.lang3.StringUtils.stripEnd;
./main/java/org/ethereum/net/rlpx/MessageCodec.java:import org.apache.commons.lang3.tuple.Pair;
./main/java/org/ethereum/solidity/compiler/SolidityCompiler.java:import static org.apache.commons.lang3.StringUtils.isNotBlank;
./test/java/co/rsk/vm/VMSpecificOpcodesPerformanceTest.java:import org.apache.commons.lang3.StringUtils;
./test/java/co/rsk/peg/RepositoryBtcBlockStoreWithCacheTest.java:import org.apache.commons.lang3.tuple.Triple;
./test/java/co/rsk/peg/BridgeSerializationUtilsTest.java:import org.apache.commons.lang3.tuple.Pair;
./test/java/co/rsk/peg/BridgeStorageProviderTest.java:import org.apache.commons.lang3.tuple.Pair;
./test/java/co/rsk/peg/StateForFederatorTest.java:import org.apache.commons.lang3.tuple.Pair;
./test/java/co/rsk/asm/EVMDissasembler.java:import static org.apache.commons.lang3.ArrayUtils.getLength;
./test/java/co/rsk/asm/EVMDissasembler.java:import static org.apache.commons.lang3.ArrayUtils.isEmpty;
./test/java/co/rsk/asm/EVMDissasembler.java:import static org.apache.commons.lang3.ArrayUtils.nullToEmpty;
./test/java/co/rsk/net/discovery/UDPServerTest.java:import org.apache.commons.lang3.StringUtils;
./test/java/co/rsk/net/discovery/PeerExplorerTest.java:import org.apache.commons.lang3.StringUtils;
./test/java/org/ethereum/util/UtilsTest.java:import org.apache.commons.lang3.tuple.Pair;
./test/java/org/ethereum/core/genesis/GenesisJsonTest.java:import org.apache.commons.lang3.StringUtils;
./test/java/org/ethereum/TestUtils.java:import org.apache.commons.lang3.StringUtils;
./test/java/org/ethereum/net/rlpx/NodeTest.java:import org.apache.commons.lang3.StringUtils;```