search

rsksmart / rwallet

The RSK Wallet is based on our rWallet open-source code-base, which will allow developers and organizations to use it to build their own apps.
https://developers.rsk.co/wallet/
GNU General Public License v3.0
43 stars 22 forks source link

I think Rwallet should allow connect to lightning wallets on custodial way using Lndhub and Lndconnect #365

Open bitcoinuser opened 4 years ago

bitcoinuser commented 4 years ago

Hi,

I don't think Rwallet should implement a non custodial lightning wallet because it's complex deal with channels..... Instead I think Rwallet should implement https://lndhub.io/about so I could link wallets like lntxbot or even Bluewallet, exporting lndhub data and importing it on Rwallet.

1- I think Rwallet on Add Wallet window, could have a new field to allow link external wallets from Third-party sources using in this example the lndhub. So on Add Wallet window, will have (Create wallet), (Import wallet) and (Link wallets). 2- When the user link a lndhub wallet, should show the main Rwallet window but with the option to add assets disabled.

bitcoinuser commented 4 years ago

Hi @chrisli30. If someone create a PR to this feature, would you accept on Rwallet? Thanks.

chrisli30 commented 4 years ago

Do you mean just by monitoring the address for an external wallet?

We already have that in the pipeline and will deliver in a couple of weeks 😄

bitcoinuser commented 4 years ago

Do you mean just by monitoring the address for an external wallet?

We already have that in the pipeline and will deliver in a couple of weeks

No, it's not this. It's like import a "private key" lndhub that gives full access to a lightning node. So I will be able to receive and send bitcoins on lightning using rwallet directly.

chrisli30 commented 4 years ago

Do you mean just by monitoring the address for an external wallet? We already have that in the pipeline and will deliver in a couple of weeks

No, it's not this. It's like import a "private key" lndhub that gives full access to a lightning node. So I will be able to receive and send bitcoins on lightning using rwallet directly.

Got it. I like it, yes if you can create a PR for this feature we would like to include it. It will be an addition to our address monitoring feature and become the 4th type of wallet.

cryptosalomao commented 4 years ago

Hello, everyone. I talked to @bitcoinuser privately, and i already started working on this. I'll be posting my progress here to discuss fixes or improvements of this proposal. I'll make a PR anytime soon. I hope it gets accepted.

chrisli30 commented 4 years ago

@cryptosalomao Awesome, are you guys based in Brazil?

cryptosalomao commented 4 years ago

@chrisli30 yes, we are. I already finished the lndhub integration, and now i'm finishing lndconnect stuff. I also have started to code the pages (plug, overview, send/receive).

bitcoinuser commented 4 years ago

Hi @chrisli30 and @cryptosalomao.

1- I think on Add wallet, the 4th wallet should have the name:

Connect Lightning Wallet

And the description:

Connect to a Third Party Service to access a Lightning Wallet.

2- After clicking on Connect to a Lightning Wallet, will appear a window like the one of Import Wallet, where the will be able to paste or read a qrcode with LNDhub or Lndconnect.

The title will be:

Connect Lightning Wallet

The description will be:

Enter the credential that gives access to a Lightning Wallet. Supported formats: LNDHub and Lndconnect.