Open AmazingBeerBelly opened 4 years ago
Nice
LRGTM! One question one advise:
eth_signTypedData
specs here https://eips.ethereum.org/EIPS/eip-712Yes, the user will be asked before signing a transaction/message. Usually, the wallet will pop a popup window to ask the user to approve or reject it. => question: is the user asked before signing a transaction/mesaage? A pop up or a notification?
Ok, thanks. I will spend some time researching eth_signTypedData => advise: eth_signTypedData specs here https://eips.ethereum.org/EIPS/eip-712
Is this already added to the app? Tried QR scanner in the last TestFlight build - from the app side it allows to connect, it even shows that the dapp is connected and allows to disconnect. However dapp itself does not receive any event about connection and just hangs with QR code opened, waiting for the connection.
Hi @grinry what dapp did you test against with? Is it on Testnet or Mainnet?
Hey @chrisli30, I tried both networks, dapp address is https://trade.sovryn.app/ Tested with ios (testflight) and android (build from source) with no luck
Flow path: