Removes the buttons to get to the swap screen.

jessgusclark commented 3 years ago

What it does

Removes access to the swap screen, which is accessible from two places:

The main tab row at the bottom. Where the new number of items is 3 and their widths are calculated based on the screen width.
From the Wallet "My Assets" summary box, the swap button. CSS alignment needed to be updated.

Screen shot from Galaxy A20e

What it is not

This does not remove the swap UI or its interaction. The UI can be used in the future with a new swap provider.

Manual testing

Pixel 3 (emulator) and Samsung Galaxy A20e (real)

Tab button row: click through the items to make sure the hitbox was correct and the spotlight (i.e. the blue line) was the correct width and placement.
Summary Card tested to make sure send and receive buttons still work, and have enough spacing between them for fat fingers.

Referenced issues

While this does not fix the issue, it is related to issues #634 and #633.

lgtm-com[bot] commented 3 years ago

This pull request introduces 3 alerts when merging 921a97516c749381282fb5a06a982c36eac6d628 into 4261f36cdc493cbd6d5eeb7e9048287a111350b2 - view on LGTM.com

new alerts: