Closed gpakosz closed 7 years ago
looks like this got fixed on the other side. sorry about delay. new year resolution to be more active here. :D thanks.
It seems asciidoctor
still has a long way to go before 1.5.6
gets released. In the meantime if you plan a stringex
release could you maybe detect #limit()
already exists and use it?
i don't think blindly using some other library's potentially random definition of #limit works in this codebase. it's impossible to know what the definition of that method might be. someone could make #limit mean something that doesn't work in StringEx's context/needs. open to pull requests [doesn't mean i except them all, obviously hehe] so let me know if you come up with something that you think could work. thanks.
Alright.
In fact could stringex
not define String#limit()
in the first place? As far as I can tell, this is an implementation detail
that would break anyone who's actually using it so i don't think that's a great solution.
asciidoctor
just started extending theString
class with#limit()
.See
asciidoctor/core_ext/string/limit.rb
and https://github.com/asciidoctor/asciidoctor/issues/1889.