rsl / stringex

Some [hopefully] useful extensions to Ruby’s String class. It is made up of three libraries: ActsAsUrl [permalink solution with better character translation], Unidecoder [Unicode to Ascii transliteration], and StringExtensions [miscellaneous helper methods for the String class].
MIT License
984 stars 158 forks source link

Backticks not always removed #195

Closed joekur closed 7 years ago

joekur commented 7 years ago

Eg:

"foo` bar".to_url # => "foo`-bar"
joekur commented 7 years ago

Also noticed that ~ does not get removed/escaped.

From https://www.ietf.org/rfc/rfc1738.txt:

These [unsafe] characters are "{", "}", "|", "\", "^", "~", "[", "]", and "`".

rsl commented 7 years ago

good catch!