codecov[bot]
commented
3 years ago Codecov Report
Merging #130 (7680e9a) into release/2.0.0 (dbfd744) will decrease coverage by
2.18%. The diff coverage is79.59%.
@@ Coverage Diff @@
## release/2.0.0 #130 +/- ##
=================================================
- Coverage 77.50% 75.32% -2.19%
=================================================
Files 28 27 -1
Lines 1218 1244 +26
Branches 182 243 +61
=================================================
- Hits 944 937 -7
- Misses 239 297 +58
+ Partials 35 10 -25 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/tests/test-utils.ts | 30.48% <37.28%> (ø) |
|
| src/modules/echo.ts | 21.27% <37.50%> (ø) |
|
| src/modules/prompt.ts | 35.29% <46.15%> (ø) |
|
| src/modules/dotnet-test.ts | 44.91% <56.66%> (ø) |
|
| src/modules/github.ts | 68.89% <67.81%> (ø) |
|
| src/modules/formatters.ts | 73.33% <73.33%> (ø) |
|
| src/modules/git.ts | 62.06% <78.57%> (ø) |
|
| src/modules/nuget-upgrade.ts | 74.13% <80.00%> (ø) |
|
| src/modules/file.ts | 60.00% <85.71%> (ø) |
|
| src/utilities/command-string-builder.ts | 85.71% <85.71%> (ø) |
|
| ... and 32 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update dbfd744...0a55fbb. Read the comment docs.
wintondeshong
brandongregoryscott
Closes #14 Investigate feasibility/benefit of porting project to Typescript
Initial pass of the TS port for the project. All automated tests should be updated & passing. There are likely some missed areas of type narrowing/specification that can be filled in later.
A few things of note:
ts-nodefor development. I was unable to use justts-nodeto run anything but the main entrypoint file, and subcommands were not registered. It required a much longer command string pointing to the tsconfig file (see https://github.com/tj/commander.js/issues/955#issuecomment-490016192 for an example)watchnpm script as theand-cli-devalias now points to<repo>/dist/and-cli.js.ts, but theTestUtilsfunction that executes the CLI commands will also reference thedistfolder for executable js files.ts-jestis throwing warnings about using jest <26. I believe jest v26+ requires node 10 and above, so we'd need to agree to move forward with that upgrade as a team - there are some implications with our Jenkins server that is still on node 8.16.3CoreUtils,CollectionUtils, etc.). So any plugin projects or older branches referencing them will need to be updated.and-cli.ts) will now export all of the shared modules for consumer use, similar to how ourandculturecode-javascript-coreandandculturecode-javascript-reactpackages export everything in theindex.tsfile.@wintondeshong This is a massive PR, so I don't expect you to scan everything line-by-line (some of the restructuring caused git to register the changes as new files entirely), but I'd love to get your input on some of this, too. In terms of releasing it, I was thinking we could release it as
2.0.0-betaversion(s) until we iron out any of the potential regressions with the port - what do you think?ts-jestwarningsInstructions for beta-testing
``` # Ensure latest and-cli is installed for access to workspace command npm i -g and-cli@latest # Ensure you are in a directory appropriate for holding OSS repos (can be anywhere, just an example) cd ~/andculturecode/forks/ # Clone all of my forks and-cli workspace -u brandongregoryscott && cd brandongregoryscott.AndcultureCode.Cli # Fetch remote branches and checkout the typescript branch git fetch && git checkout feature/typescript # Install dependencies and run a build npm install && npm run build # Install the CLI aliases ./dist/and-cli.js install Now you can run the built JS version of the CLI by running `and-cli-dev` ```Command audit/testing checklist
- [x] `copy` - [x] `-d, --destination