dylanjustice commented 3 years ago

Resolves #158 Allow user to opt out of the node clean and restore. Allow user to leverage npm ci command

[x] Related GitHub issue(s) linked in PR description
[x] Destination branch merged, built and tested with your changes
[x] Code formatted and follows best practices and patterns
[x] Code builds cleanly (no additional warnings or errors)
[x] Manually tested
[x] Automated tests are passing (and-cli-dotnet-test failures due to known issue)
[x] No decreases in automated test coverage
[x] Documentation updated (readme, docs, comments, etc.)
[x] Localization: No hard-coded error messages in code files (minimally in string constants)

codecov[bot] commented 3 years ago

Codecov Report

Merging #159 (eec9765) into main (1d9e4dd) will decrease coverage by 1.83%. The diff coverage is 54.00%.

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   76.65%   74.82%   -1.84%     
==========================================
  Files          33       39       +6     
  Lines        1328     1426      +98     
  Branches      249      262      +13     
==========================================
+ Hits         1018     1067      +49     
- Misses        300      349      +49     
  Partials       10       10

Impacted Files	Coverage Δ
src/tests/factories/factory-type.ts	`100.00% <ø> (ø)`
src/modules/node-clean.ts	`43.75% <20.00%> (ø)`
src/modules/node-restore.ts	`41.17% <28.57%> (ø)`
src/modules/node-ci.ts	`35.00% <35.00%> (ø)`
src/modules/webpack-publish.ts	`57.14% <92.30%> (ø)`
src/tests/factories/index.ts	`100.00% <100.00%> (ø)`
...tests/factories/webpack-restore-options-factory.ts	`100.00% <100.00%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d9e4dd...eec9765. Read the comment docs.

dylanjustice commented 3 years ago

@wintondeshong Have a few minutes to take an additional pass here? Loved the first round of feedback.

brandongregoryscott commented 3 years ago

@all-contributors please add @dylanjustice for code, maintenance, tests

allcontributors[bot] commented 3 years ago

@brandongregoryscott

I've put up a pull request to add @dylanjustice! :tada: