rsm-hcd / AndcultureCode.Cli

and-cli command-line tool to manage the development of software applications
https://andculture.com
Apache License 2.0
14 stars 15 forks source link

Bug fix for webpack clean without restore #167

Closed brandongregoryscott closed 3 years ago

brandongregoryscott commented 3 years ago

Extract Webpack module, force exit after clean if not restoring, break out repeated options into constant file

Fixes #133 webpack clean without restore causes error

codecov[bot] commented 3 years ago

Codecov Report

Merging #167 (d883ba1) into main (2278dc2) will decrease coverage by 0.26%. The diff coverage is 52.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   75.20%   74.94%   -0.27%     
==========================================
  Files          40       41       +1     
  Lines        1436     1453      +17     
  Branches      228      263      +35     
==========================================
+ Hits         1080     1089       +9     
+ Misses        355      354       -1     
- Partials        1       10       +9     
Impacted Files Coverage Δ
src/modules/constants.ts 100.00% <ø> (ø)
src/modules/webpack-publish.ts 51.16% <16.66%> (-5.99%) :arrow_down:
src/modules/node-restore.ts 44.44% <50.00%> (+3.26%) :arrow_up:
src/modules/node-clean.ts 46.66% <60.00%> (+2.91%) :arrow_up:
src/modules/dotnet-restore.ts 86.95% <66.66%> (-3.96%) :arrow_down:
src/modules/dotnet-clean.ts 93.61% <75.00%> (-2.04%) :arrow_down:
src/constants/options.ts 100.00% <100.00%> (ø)
src/modules/dotnet-build.ts 88.88% <0.00%> (-3.71%) :arrow_down:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2278dc2...ade1c02. Read the comment docs.

brandongregoryscott commented 3 years ago

Looking into these build failures ☝️ I don't think it is the result of anything in the code, probably just flakiness being exposed from the increased frequency of builds. I'll open a separate issue to handle those: #171

brandongregoryscott commented 3 years ago

@all-contributors please add @KevinBusch for review

allcontributors[bot] commented 3 years ago

@brandongregoryscott

I've put up a pull request to add @KevinBusch! :tada: