rsm-hcd / AndcultureCode.Cli

and-cli command-line tool to manage the development of software applications

https://andculture.com

Apache License 2.0

14 stars 15 forks source link

Jenkins deploy script 🐛 fix and new Health check feature #196

Closed dylanjustice closed 3 years ago

dylanjustice commented 3 years ago

195 Jenkins deploy did not account for a string with spaces in it. Curl command would fail.

194 Porting health check command for more generic usage.

[x] Related GitHub issue(s) linked in PR description
[x] Destination branch merged, built and tested with your changes
[x] Code formatted and follows best practices and patterns
[x] Code builds cleanly (no additional warnings or errors)
[x] Manually tested
[x] Automated tests are passing
[x] No decreases in automated test coverage
[x] Documentation updated (readme, docs, comments, etc.)
[x] Localization: No hard-coded error messages in code files (minimally in string constants)

brandongregoryscott commented 3 years ago

Also, one more thought - the git commit history here looks pretty old, probably from some old branches. Mind squashing this down to just a commit to keep our history clean?

dylanjustice commented 3 years ago

Left some refactoring food for thought, but thanks for pulling this into the main CLI 👍

Thanks for the feedback! All good recommendations.

dylanjustice commented 3 years ago

Also, one more thought - the git commit history here looks pretty old, probably from some old branches. Mind squashing this down to just a commit to keep our history clean? @brandongregoryscott All set. Not sure what that was about. Just needed the ole reset.

dylanjustice commented 3 years ago

@all-contributors please add @AaronW for review

allcontributors[bot] commented 3 years ago

@dylanjustice

I've put up a pull request to add @AaronW! :tada: