rsm-hcd / AndcultureCode.Cli

and-cli command-line tool to manage the development of software applications
https://andculture.com
Apache License 2.0
14 stars 15 forks source link

Fix Elastic Beanstalk CLI default timeout of 10 minutes causing unexpected failures #35

Closed wintondeshong closed 4 years ago

wintondeshong commented 4 years ago

Problem The default for the Elastic beanstalk CLI is to timeout if a deploy takes longer than 10 minutes. Depending up on your rolling strategy, health monitoring, etc... that could very well likely happen. This results in the CLI returning an error even though beanstalk will likely continue on a deploy successfully.

ERROR: TimeoutError - The EB CLI timed out after 10 minute(s). The operation might still be running. To keep viewing events, run 'eb events -f'. To set timeout duration, use '--timeout MINUTES'.
[and-cli] [ERROR]  - Failed to deploy to AWS beanstalk

Solution Lets increase the default timeout (--timeout) flag sent to awsebcli from 10 minutes to 20 minutes. Additionally, lets provide an optional argument to override it. That way we don't need to keep moving the "needle" and we don't hold up edge use cases that happen to exceed the limit legitimately.

wintondeshong commented 4 years ago

I'm tackling this issue now