Closed brandongregoryscott closed 4 years ago
Merging #66 into master will increase coverage by
26.72%
. The diff coverage is94.18%
.
@@ Coverage Diff @@
## master #66 +/- ##
===========================================
+ Coverage 42.62% 69.34% +26.72%
===========================================
Files 13 13
Lines 366 398 +32
Branches 58 66 +8
===========================================
+ Hits 156 276 +120
+ Misses 171 101 -70
+ Partials 39 21 -18
Impacted Files | Coverage Δ | |
---|---|---|
_modules/constants.js | 100.00% <ø> (ø) |
|
_modules/dir.js | 100.00% <ø> (+58.33%) |
:arrow_up: |
_modules/dotnet-test.js | 35.95% <ø> (-2.25%) |
:arrow_down: |
_modules/file.js | 45.00% <ø> (ø) |
|
_modules/nuget-upgrade.js | 72.22% <ø> (ø) |
|
_modules/user-prompt.js | 38.46% <0.00%> (ø) |
|
_modules/variables.js | 100.00% <ø> (ø) |
|
_modules/dotnet-restore.js | 94.44% <93.75%> (+44.44%) |
:arrow_up: |
_modules/dotnet-build.js | 95.65% <100.00%> (+59.28%) |
:arrow_up: |
_modules/dotnet-clean.js | 97.61% <100.00%> (+75.03%) |
:arrow_up: |
... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7ed3d74...68595fc. Read the comment docs.
@brandongregoryscott The only other comment, unrelated to the code itself, is to try your best to provide more detail to your commit descriptions given we are not doing a squash strategy. Absolutely dig your frequent committing, but one small area for improvement. Many are good to go, but a few are a bit general.
Thanks for the feedback @wintondeshong! I'll take care of these changes and get this in today. I didn't realize we weren't squashing here, so I might try to make it a habit to squash before I post up a PR. I know my git history can be pretty chaotic 😝
Took care of all those changes and squashed my own code down to 1 commit. Merging to master now.
Closes issue #65
Adds test coverage for the following modules:
dir.js
dotnet-build.js
dotnet-clean.js
dotnet-path.js
dotnet-restore.js
Additional work/refactors:
dotnet-build.js
to usespawnSync
for streaming, colored outputdotnet-clean.js
to usespawnSync
for streaming, colored outputdotnet-restore.js
to usespawnSync
for streaming, colored outputdotnet-clean.js
dotnet-path.js
setupTests.js
for global mocking/module overrides to prevent common pitfalls